build: expand the swift components and create install rules #21270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the component system with the LLVM installation mechanism. This allows for a single unified toolchain build. Preserve the components by remapping the swift components to their substiutients during the configure phase.
|
Something that I was playing with, it may be interesting to finish off and merge |
gottesmm
reviewed
Dec 12, 2018
| @@ -454,12 +454,14 @@ include(CMakePushCheckState) | |||
| print_versions() | |||
|
|
|||
| include(SwiftComponents) | |||
|
|
|||
| swift_expand_components() | |||
There was a problem hiding this comment.
Can you hide this in configure_components?
|
It just seems that having this be mapped away is easier to deal with the CMake logic overall. Really, the component mapping doesn't change very often, and most of that can be abstracted over with caches, so this seems better for the regular read/modify cycle of the CMake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the component system with the LLVM installation mechanism. This allows
for a single unified toolchain build. Preserve the components by remapping the
swift components to their substiutients during the configure phase.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.