[5.0] [IRGen] Do not write out ObjC property ivar field for static properties #21481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[IRGen] Do not write out ObjC property ivar field for static properties
|
@swift-ci Please test |
AnnaZaks
approved these changes
Dec 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Objective-C properties have metadata for run-time use, but we were including some information that's only meant for instance properties: the name of the backing storage. Class properties, of course, don't have instance variables backing them, even if they are stored.
Scope: Affects the ObjC metadata for class properties.
Issue: SR-9541 / rdar://problem/46830117
Risk: Very low. There's no format change here, just an omission of information that is incorrect.
Testing: Added compiler regression tests.
Reviewed by: me (patch by @zneak)