[Parse] Eliminate backtracking in collection expression parsing #21487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
rintaro
commented
Dec 21, 2018
| @@ -1,7 +1,7 @@ | |||
| // RUN: %target-swift-frontend -Xllvm -sil-full-demangle -profile-generate -profile-coverage-mapping -emit-sil -module-name coverage_closures %s | %FileCheck %s | |||
|
|
|||
| func bar(arr: [(Int32) -> Int32]) { | |||
| // CHECK-LABEL: sil_coverage_map {{.*}}// closure #2 (Swift.Int32) -> Swift.Int32 in coverage_closures.bar | |||
| // CHECK-LABEL: sil_coverage_map {{.*}}// closure #1 (Swift.Int32) -> Swift.Int32 in coverage_closures.bar | |||
There was a problem hiding this comment.
Previously, local discriminator #1 used to be consumed during backtracking.
|
Cool, I wonder if your PR fixes this bug too: https://github.com/apple/swift/pull/15619/files#diff-1a9565d4ad49da3f2dcb708fa95d21a3 |
nkcsgexi
approved these changes
Dec 21, 2018
Parsing collection literal expression used to take exponential time depending on the nesting level of the first element. Stop using 'parseList()' because using it complicates libSyntax parsing. rdar://problem/45221238 / https://bugs.swift.org/browse/SR-9220 rdar://problem/38913395 / https://bugs.swift.org/browse/SR-7283
rintaro
force-pushed
the
parse-collection-rdar45221238
branch
from
9cdad2c
to
22652f9
Compare
|
@slavapestov Yes this PR fixes that. Thank you for the link. I added a test case from #15619 . |
|
@swift-ci Please smoke test |
This was referenced Jan 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parsing collection literal expression used to take exponential time depending on the nesting level of the first element.
Stop using
parseList()because using it complicates libSyntax parsing.SR-9220 / rdar://problem/45221238
SR-7283 / rdar://problem/38913395