Taught IRGen to support tensor-typed attributes with a scalar string as the value #21492
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
string-tensor-typed attributes are usually to represent metadata like file names in a dataset TF op, so scalar tensor support should be sufficient.
Extending the code to also support string-tensors of arbitrary shapes would involve extending
createArrayAndSize()
and the runtime functionswift_tfc_CreateScalarStringTensor()
, which adds complexity without sufficient justification for now.Resolves SR-9555.