Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sema] Add warning for ambiguous value assignment when using Optional #21621

Merged
merged 51 commits into from
Jan 8, 2019
Merged

[Sema] Add warning for ambiguous value assignment when using Optional #21621

merged 51 commits into from
Jan 8, 2019

Commits on Jan 4, 2019

  1. [sema] emit a diag if the enum case matches Optional<T>.none

    Suyash Srijan authored and Suyash Srijan committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    5501bee View commit details
    Browse the repository at this point in the history

  2. [test] update tests

    Suyash Srijan authored and Suyash Srijan committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    39db6a2 View commit details
    Browse the repository at this point in the history

  3. [sema] fix indent

    Suyash Srijan authored and Suyash Srijan committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    fea7221 View commit details
    Browse the repository at this point in the history

  4. [test] fix indent

    @theblixguy
    theblixguy committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    3e295b1 View commit details
    Browse the repository at this point in the history

  5. [test] add more test cases

    @theblixguy
    theblixguy committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    193dfa4 View commit details
    Browse the repository at this point in the history

  6. [test] add even more test cases

    @theblixguy
    theblixguy committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    07fb819 View commit details
    Browse the repository at this point in the history

  7. [sema] move the check to CSApply

    Suyash Srijan authored and Suyash Srijan committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    ffcf5ef View commit details
    Browse the repository at this point in the history

  8. [diag] update diagnostic message

    Suyash Srijan authored and Suyash Srijan committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    e9bd7c9 View commit details
    Browse the repository at this point in the history

  9. [test] update tests

    Suyash Srijan authored and Suyash Srijan committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    08150d2 View commit details
    Browse the repository at this point in the history

  10. [test] resolve conflict

    Suyash Srijan authored and Suyash Srijan committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    19cff10 View commit details
    Browse the repository at this point in the history

  11. [test] fix conflicts

    Suyash Srijan authored and Suyash Srijan committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    2862ff0 View commit details
    Browse the repository at this point in the history

  12. [diag] reflow lines

    Suyash Srijan authored and Suyash Srijan committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    71f3092 View commit details
    Browse the repository at this point in the history

  13. [sema] reindent using spaces

    Suyash Srijan authored and Suyash Srijan committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    599ab70 View commit details
    Browse the repository at this point in the history

  14. Merge remote-tracking branch 'upstream/master' into fix/SR-2176

    Suyash Srijan authored and Suyash Srijan committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    8ae8d58 View commit details
    Browse the repository at this point in the history

  15. [test] adds new line

    Suyash Srijan authored and Suyash Srijan committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    6ab5268 View commit details
    Browse the repository at this point in the history

  16. [diag] update diagnostic message

    Suyash Srijan authored and Suyash Srijan committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    3ed50ba View commit details
    Browse the repository at this point in the history

  17. [sema] add support for structs as well

    Suyash Srijan authored and Suyash Srijan committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    c3fae9a View commit details
    Browse the repository at this point in the history

  18. [test] add more test cases

    Suyash Srijan authored and Suyash Srijan committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    d140e9e View commit details
    Browse the repository at this point in the history

  19. [sema] check for enum assoc values

    Suyash Srijan authored and Suyash Srijan committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    0710127 View commit details
    Browse the repository at this point in the history

  20. [test] add more test cases

    Suyash Srijan authored and Suyash Srijan committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    37dd800 View commit details
    Browse the repository at this point in the history

  21. [diag] add fixit notes

    Suyash Srijan authored and Suyash Srijan committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    7ac619e View commit details
    Browse the repository at this point in the history

  22. [sema] emit fix its

    Suyash Srijan authored and Suyash Srijan committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    b846c4e View commit details
    Browse the repository at this point in the history

  23. [diag] rename diag names

    Suyash Srijan authored and Suyash Srijan committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    b7ffac3 View commit details
    Browse the repository at this point in the history

  24. [sema] fit within 80 char line limit

    Suyash Srijan authored and Suyash Srijan committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    3d6ecfc View commit details
    Browse the repository at this point in the history

  25. [sema] use baseUnwrappedType's name directly

    Suyash Srijan authored and Suyash Srijan committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    ba13f9f View commit details
    Browse the repository at this point in the history

  26. [test] adds nested generic enum tests

    Suyash Srijan authored and Suyash Srijan committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    7a47674 View commit details
    Browse the repository at this point in the history

  27. [test] fix indent

    @theblixguy
    theblixguy committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    5a89456 View commit details
    Browse the repository at this point in the history

  28. [test] adds fixit check

    Suyash Srijan authored and Suyash Srijan committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    6b8343b View commit details
    Browse the repository at this point in the history

  29. Merge branch 'fix/SR-2176' of https://github.com/theblixguy/swift int… 

    …o fix/SR-2176
    Suyash Srijan authored and Suyash Srijan committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    fe57f14 View commit details
    Browse the repository at this point in the history

  30. [test] re-indent some enums

    @theblixguy
    theblixguy committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    dceb43c View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2019

  1. [sema] [csapply] extract code into a separate function

    Suyash Srijan authored and Suyash Srijan committed Jan 5, 2019
    Configuration menu
    Copy the full SHA
    6be62cd View commit details
    Browse the repository at this point in the history

  2. [sema] [csapply] remove redundant vardecl check

    Suyash Srijan authored and Suyash Srijan committed Jan 5, 2019
    Configuration menu
    Copy the full SHA
    f08670f View commit details
    Browse the repository at this point in the history

  3. [sema] [csapply] reindent

    Suyash Srijan authored and Suyash Srijan committed Jan 5, 2019
    Configuration menu
    Copy the full SHA
    b470f22 View commit details
    Browse the repository at this point in the history

  4. [sema] [csapply] removes extra line

    Suyash Srijan authored and Suyash Srijan committed Jan 5, 2019
    Configuration menu
    Copy the full SHA
    fabd559 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2019

  1. Merge remote-tracking branch 'upstream/master' into fix/SR-2176

    Suyash Srijan authored and Suyash Srijan committed Jan 6, 2019
    Configuration menu
    Copy the full SHA
    d7da34b View commit details
    Browse the repository at this point in the history

  2. [sema] [csapply] use cantype & check for extension on Optional

    Suyash Srijan authored and Suyash Srijan committed Jan 6, 2019
    Configuration menu
    Copy the full SHA
    aacc63e View commit details
    Browse the repository at this point in the history

  3. [diag] update diagnostic message

    Suyash Srijan authored and Suyash Srijan committed Jan 6, 2019
    Configuration menu
    Copy the full SHA
    268b9db View commit details
    Browse the repository at this point in the history

  4. [sema] [csapply] fix ident

    Suyash Srijan authored and Suyash Srijan committed Jan 6, 2019
    Configuration menu
    Copy the full SHA
    5c9d5ce View commit details
    Browse the repository at this point in the history

  5. [test] update tests

    Suyash Srijan authored and Suyash Srijan committed Jan 6, 2019
    Configuration menu
    Copy the full SHA
    16b2eae View commit details
    Browse the repository at this point in the history

  6. [sema] [csapply] fix typo and remove redundant isOptional check

    Suyash Srijan authored and Suyash Srijan committed Jan 6, 2019
    Configuration menu
    Copy the full SHA
    06e0678 View commit details
    Browse the repository at this point in the history

  7. [sema] [csapply] update var name & comments

    Suyash Srijan authored and Suyash Srijan committed Jan 6, 2019
    Configuration menu
    Copy the full SHA
    87344c8 View commit details
    Browse the repository at this point in the history

  8. [sema] [csapply] bring back isOptional check

    Suyash Srijan authored and Suyash Srijan committed Jan 6, 2019
    Configuration menu
    Copy the full SHA
    1f6ea3d View commit details
    Browse the repository at this point in the history

  9. [test] add expected-note for fix-its

    Suyash Srijan authored and Suyash Srijan committed Jan 6, 2019
    Configuration menu
    Copy the full SHA
    ed10386 View commit details
    Browse the repository at this point in the history

  10. [sema] [csapply] fix a crash

    Suyash Srijan authored and Suyash Srijan committed Jan 6, 2019
    Configuration menu
    Copy the full SHA
    95e3f1d View commit details
    Browse the repository at this point in the history

  11. [sema] [csapply] move isOptional check outside

    Suyash Srijan authored and Suyash Srijan committed Jan 6, 2019
    Configuration menu
    Copy the full SHA
    1a38061 View commit details
    Browse the repository at this point in the history

  12. [test] fix indent

    @theblixguy
    theblixguy committed Jan 6, 2019
    Configuration menu
    Copy the full SHA
    da09422 View commit details
    Browse the repository at this point in the history

  13. [test] fix typo

    @theblixguy
    theblixguy committed Jan 6, 2019
    Configuration menu
    Copy the full SHA
    bb30682 View commit details
    Browse the repository at this point in the history

  14. [sema] [csapply] use baseTyUnwrapped for fixit

    Suyash Srijan authored and Suyash Srijan committed Jan 6, 2019
    Configuration menu
    Copy the full SHA
    07e8717 View commit details
    Browse the repository at this point in the history

  15. [test] fix columns for fixits

    Suyash Srijan authored and Suyash Srijan committed Jan 6, 2019
    Configuration menu
    Copy the full SHA
    cf23de4 View commit details
    Browse the repository at this point in the history

  16. [test] update column numbers

    Suyash Srijan authored and Suyash Srijan committed Jan 6, 2019
    Configuration menu
    Copy the full SHA
    d226b02 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2019

  1. [sema] [csapply] move code out of for loop

    Suyash Srijan authored and Suyash Srijan committed Jan 7, 2019
    Configuration menu
    Copy the full SHA
    0fc9c8b View commit details
    Browse the repository at this point in the history