[AutoDiff] Fix activity analysis for side-effecting instructions. #21826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Now, all address-operands of side-effecting instructions are marked as
useful only if any result is useful.
- This enables differentiation of non-useful mutation (so functions can
mutate outside state).
- Previously, all address-operands and results of side-effecting
instructions were unconditionally marked as useful.
- If the source of an "modifying" side-effecting instruction
(e.g. `store` or `copy_addr`) is varied, recursively mark results
and their operands as varied.
|
@swift-ci Please test tensorflow |
rxwei
approved these changes
Jan 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, all address-operands of side-effecting instructions are marked as
useful only if any result is useful.
mutate outside state).
instructions were unconditionally marked as useful.
If the source of an "modifying" side-effecting instruction
(e.g.
storeorcopy_addr) is varied, recursively mark resultsand their operands as varied.