[AutoDiff] Enable differentiation of generic functions. #22023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Relax differentiability diagnostic for generic functions.
- Previously, an error was emitted when attempting to differentiate any
generic function. Now, diagnose only functions with indirect
differentiation parameters/result.
- Propagate differentiation associated function generic signature throughout
differentiation pass.
- Change `PrimalGenCloner` to inherit `TypeSubstCloner`.
- Make primal value structs inherit primal function's generic parameters
and signature.
- Calculate correct substitution map for `PrimalGenCloner::visitApplyInst`.
Emit diagnostic when apply instruction's associated function (e.g. VJP)
has generic requirements unmet by the primal generic environment.
- Remap types in `AdjointEmitter`.
- Remove manually `@differentiable` attribute where clause conformance
requirement checks.
- `GenericSignatureBuilder` already performs checks so manual checks are
unnecessary.
dan-zheng
force-pushed
the
enable-generic-differentiation
branch
from
6b0e269
to
e2155bf
Compare
rxwei
reviewed
Jan 21, 2019
TODO: Add more tests.
rxwei
approved these changes
Jan 21, 2019
|
@swift-ci Please test tensorflow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generic function. Now, diagnose only functions with indirect
differentiation parameters/result.
differentiation pass.
PrimalGenClonerto inheritTypeSubstCloner.and signature.
PrimalGenCloner::visitApplyInst.Emit diagnostic when apply instruction's associated function (e.g. VJP)
has generic requirements unmet by the primal generic environment.
AdjointEmitter.@differentiableattribute where clause conformancerequirement checks.
GenericSignatureBuilderalready performs checks so manual checks areunnecessary.