[AutoDiff] Add an error when @differentiable attributes do not match. #22149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test tensorflow |
1 similar comment
|
@swift-ci please test tensorflow |
|
@swift-ci please test tensorflow |
1 similar comment
|
@swift-ci please test tensorflow |
…when conforming to protocols.
|
@swift-ci please test tensorflow |
|
@swift-ci please test tensorflow macos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a mismatch between differentiable attributes on protocol and structs that conform to that protocol will result in a runtime error.
This PR adds a diagnostic error that always requires that these functions be differentiable.
This is an example of the diagnostic that is produced when this happens:
test2.swift:9:8: error: type 'ConformingWithErrors' does not conform to protocol 'DiffReq'
struct ConformingWithErrors : DiffReq {
^
test2.swift:10:8: note: candidate is missing differentiable attribute '@differentiable(wrt: (x, self)) '
func f1(_ x: Float) -> Float {
^
test2.swift:3:8: note: protocol requires function 'f1' with type '(Float) -> Float'; do you want to add a stub?
func f1(_ x: Float) -> Float
^