[stdlib] Remove overly-permissive UnsafePointer init #22288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
Please test with following pull request: @swift-ci please test linux platform |
|
@swift-ci please test macOS platform |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
atrick
approved these changes
Feb 1, 2019
There was a problem hiding this comment.
I'll approve under the assumption that you'll add tests in UnsafePointerDiagnostics.swift something like this:
_ = UnsafePointer<Int>(ps) // expected-error {{error: cannot convert value of type 'UnsafePointer<String>' to expected argument type 'UnsafePointer<_>'}}
_ = UnsafeMutablePointer<Int>(mps) // expected-error {{error: cannot convert value of type 'UnsafeMutablePointer<String>' to expected argument type 'UnsafeMutablePointer<_>'}}
_ = UnsafePointer<String>(pi) // expected-error {{error: cannot convert value of type 'UnsafePointer<Int>' to expected argument type 'UnsafePointer<_>'}}
_ = UnsafeMutablePointer<String>(mpi) // expected-error {{error: cannot convert value of type 'UnsafeMutablePointer<Int>' to expected argument type 'UnsafeMutablePointer<_>'}}
|
apple/swift-corelibs-foundation#1870 |
|
@swift-ci Please test macOS platform |
|
Build failed |
|
Build failed |
moiseev
approved these changes
Feb 1, 2019
|
@swift-ci please smoke test and merge |
|
@swift-ci Please smoke test Linux platform |
akyrtzi
added a commit
to akyrtzi/swift-syntax
that referenced
this pull request
Feb 13, 2019
The errors were introduced due to apple/swift#22288
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-on building on #22275 removing the generic init, leaving only the inits from that PR