Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[benchmark] Remove unused function get_results #22341

Merged
merged 1 commit into from Feb 11, 2019

Conversation

palimondo
Copy link
Collaborator

Remove the get_results function, which is no longer used after the refactoring that rebased the benchmark measurements on BenchmarDriver class in #21684.

Remove the `get_results` function, which is no longer used after the refactoring that rebased the benchmark measurements on `BenchmarDriver` class in #21684.
@palimondo
Copy link
Collaborator Author

@swift-ci please benchmark

@palimondo
Copy link
Collaborator Author

@swift-ci please smoke test

@swift-ci
Copy link
Collaborator

swift-ci commented Feb 4, 2019

Build comment file:

Performance: -O

TEST OLD NEW DELTA RATIO
Improvement
DataAppendDataLargeToLarge 51200 38000 -25.8% 1.35x (?)
How to read the data The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB
--------------

@palimondo
Copy link
Collaborator Author

@eeckstein Please review 🙏

@gottesmm
Copy link
Member

gottesmm commented Feb 4, 2019

@palimondo just an FYI, @eeckstein is on vacation this week. So he will be unable to review until next week. I would wait until then for review.

@palimondo
Copy link
Collaborator Author

@gottesmm Thank's for the heads up! Could you please take over the review? This is just a triviality… cleaning up a leftover from month ago.

@gottesmm
Copy link
Member

gottesmm commented Feb 4, 2019

Sorry, I am not available for review for this code.

@palimondo palimondo removed the request for review from gottesmm February 4, 2019 19:16
@eeckstein eeckstein merged commit e3e69f7 into master Feb 11, 2019
@palimondo
Copy link
Collaborator Author

Thank you Erik!

@palimondo palimondo deleted the clear-smoke-bench-unused branch February 11, 2019 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants