Run the Python linter more often #22555
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was only run during validation tests, so issues have accumulated.
The Python linter has not been run during smoke tests until now, so various issues have accumulated. This change fixes them.
|
@brentdax I thought we ran this when we smoke tested, no? |
|
@swift-ci please python lint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out we have a Python linter! Who knew? Unfortunately, it only ran during validation tests, so you would generally discover this by waiting four hours for CI to validate an important change, only to find that it failed because you forgot to alphabetize your import statements. This was not conducive to healthy blood pressure.
This PR
runs the linter during smoke testsmoves the linter into test/ so that mistakes will be caught more quickly and frequently. The PR also fixes a number of linter issues in existing Python code.