Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-10155] Support string interpolations with binary value #23510

Open
wants to merge 1 commit into
base: master
from

Conversation

@S-Shimotori
Copy link

commented Mar 23, 2019

I made OSLog support String interpolations with binary value, not only hex, octal and decimal.

See:
https://github.com/apple/swift/pull/22914/files#diff-67e352846aa55b916212d76f5f4afda1R229
https://bugs.swift.org/browse/SR-10155

@S-Shimotori

This comment has been minimized.

Copy link
Author

commented Mar 23, 2019

@swift-ci Please smoke test

Sorry I understand I have no authority

@harlanhaskins harlanhaskins requested a review from ravikandhadai Mar 25, 2019

@harlanhaskins

This comment has been minimized.

Copy link
Collaborator

commented Mar 25, 2019

Welcome, @S-Shimotori! I've added @ravikandhadai as a reviewer to look at this. Thanks for your contribution!

@swift-ci please smoke test

@xwu

This comment has been minimized.

Copy link
Collaborator

commented Mar 30, 2019

@swift-ci please smoke test Linux platform

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.