[SR-10155] Support string interpolations with binary value #23510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry I understand I have no authority |
|
Welcome, @S-Shimotori! I've added @ravikandhadai as a reviewer to look at this. Thanks for your contribution! @swift-ci please smoke test |
|
@swift-ci please smoke test Linux platform |
|
I think this PR can be closed. The code base has changed quite a bit, and the os_log overlay code in the compiler is just for testing the compiler optimizations. Thanks @S-Shimotori for your efforts. I would like to encourage you to continue your contributions to the mainstream Swift compiler code base. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made OSLog support String interpolations with binary value, not only hex, octal and decimal.
See:
https://github.com/apple/swift/pull/22914/files#diff-67e352846aa55b916212d76f5f4afda1R229
https://bugs.swift.org/browse/SR-10155