[ConstraintSystem] Delay adding contextual requirements until parent … #23652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In release builds this manifests as infinite loop in |
DougGregor
approved these changes
Mar 29, 2019
…type is opened `openUnboundGenericType` eagerly tries to add conditional requirements associated with chain of parents of the given type if type has been declared inside of constrained extension. But one of the parent types might be unbound e.g. `A.B` which means it has to be opened, which by itself, would add such requirements. Resolves: rdar://problem/49371608
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…type is opened
openUnboundGenericTypeeagerly tries to add conditional requirementsassociated with chain of parents of the given type if type has been
declared inside of constrained extension. But one of the parent types
might be unbound e.g.
A.Bwhich means it has to be opened, whichby itself, would add such requirements.
Resolves: rdar://problem/49371608