Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stdlib] Include POSIXError as part of Glibc #24028

Merged
merged 1 commit into from Apr 16, 2019

Conversation

colemancda
Copy link
Contributor

@colemancda colemancda commented Apr 14, 2019

POSIXErrorCode is compiled as part of the platform module on Darwin, but not as part of Glibc on Linux and other platforms. This PR makes the platforms consistently define POSIXErrorCode which should have been compiling for Linux since 8157194#diff-c86969eead9d9f63ad0faa3e75802e66R268.

Resolves SR-10485.

colemancda added a commit to PureSwift/Bluetooth that referenced this pull request Apr 14, 2019
colemancda added a commit to colemancda/swift-corelibs-foundation that referenced this pull request Apr 14, 2019
@compnerd
Copy link
Collaborator

@swift-ci please test

@swift-ci
Copy link
Collaborator

Build failed
Swift Test OS X Platform
Git Sha - 787bc36

@colemancda
Copy link
Contributor Author

@compnerd Builds fine on Linux, not sure what the issue is with macOS.

18:45:51 ERROR: Step ‘Publish xUnit test result report’ failed: [JUnit] - No test report file(s) were found with the pattern 'branch-master/buildbot_incremental/swift-macosx-x86_64/swift-test-results/**/*.xml' relative to '/Users/buildnode/jenkins/workspace/swift-PR-osx' for the testing framework 'JUnit'.
18:45:51 Did you enter a pattern relative to (and within) the workspace directory?
18:45:51 Did you generate the result report(s) for 'JUnit'?"
18:45:51 [BFA] Scanning build for known causes...
18:45:51 [BFA] No failure causes found
18:45:51 [BFA] Done. 0s
18:45:51 Adding one-line test results to commit status...
18:45:51 Setting status of 787bc36f6d0b68c95052ce70ab90fa7145c4fabc to FAILURE with url https://ci.swift.org/job/swift-PR-osx/12537/ and message: 'Build finished. No test results found.'
18:45:51 Using context: Swift Test OS X Platform
18:45:51 **Build failed**

colemancda added a commit to PureSwift/BluetoothLinux that referenced this pull request Apr 15, 2019
@compnerd
Copy link
Collaborator

@swift-ci please test macOS platform

@compnerd compnerd merged commit b6ca2fb into apple:master Apr 16, 2019
colemancda added a commit to colemancda/swift-corelibs-foundation that referenced this pull request Apr 16, 2019
POSIXErrorCode is now built as part of Glibc

apple/swift#24028
@colemancda colemancda deleted the posixErrorGlibc branch April 16, 2019 07:12
colemancda added a commit to colemancda/swift-corelibs-foundation that referenced this pull request Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants