Fixed POSIXError for Linux
#122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should not use `POSIXError.Code` on Linux since it is currently broken. apple/swift-corelibs-foundation#2113
Use `POSIXErrorCode` to validate `errno` value. apple/swift-corelibs-foundation#2113
|
Failing on Linux That should be part of Glibc per apple/swift@8157194#diff-c86969eead9d9f63ad0faa3e75802e66R268 and apple/swift-corelibs-foundation#933 (comment) |
|
@CodaFi Any ideas why |
|
Waiting on apple/swift#24028 to be merged for this to work. |
Since it is not compiled with Glibc yet https://bugs.swift.org/browse/SR-10485 apple/swift#24028 apple/swift-corelibs-foundation#2113
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR Do?
Should not use
POSIXError.Codeon Linux since it is currently broken.apple/swift-corelibs-foundation#2113
Where should the reviewer start?
POSIXError.swiftSweet giphy showing how you feel about this PR