[Serialization] Factor TypeSerializer out of writeType #25043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like the recent change for DeclSerializer. No functionality change, just making it easier to read.
No functionality change.
...and carry no other information (besides their record code). No functionality change.
...well, at least a little more than before. This /still/ isn't as strong as the switch that used to be here because a subtype of an existing Decl or Type won't show up, but that's probably still worth the maintainability (and backtrace) tradeoff.
|
@swift-ci Please test |
slavapestov
approved these changes
May 24, 2019
|
Build failed |
|
@swift-ci Please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like #25005 but for types instead of decls; also like #22666 but for serialization instead of deserialization. No functionality change.