[SR-710][Index] isTestCandidate access for Linux #2518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal for https://bugs.swift.org/browse/SR-710 is to automatically generate a list of tests to run for XCTest on Linux. The prevailing approach is to generate this list using SourceKit, which is to be ported to Linux. SourceKit uses libIndex's concept of `isTestCandidate` to determine what constitutes a test. `isTestCandidate` is tested via `test/SourceKit/Indexing/index.swift`. On Linux, however, the list of tests to be run will be generated by some tool and placed in a file that is separate from the source file that defines the test method. Therefore, the test method must not be "private", since it needs to be accessed from a separate file. This commit adds two test files: one that verifies the behavior on Linux, and one that verifies the behavior on platforms with Objective-C interop. It also (1) simplifies the `isTestCandidate` function, and (2) adds the interop-specific logic. This commit does not remove the existing `isTestCandidate` tests in `test/SourceKit/Indexing/index.swift`; that is left for a future commit.
1 task
|
@swift-ci please test |
|
The failing test on OS X, @akyrtzi, care to take a look at this? |
|
@swift-ci Please test OS X platform |
|
Thanks for pinging this, @briancroom. I still think it's something we should merge. @akyrtzi, @benlangmuir, any thoughts here? |
|
LGTM |
|
Great, thanks! 💯 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
The goal for https://bugs.swift.org/browse/SR-710 is to automatically generate a list of tests to run for XCTest on Linux. The prevailing approach is to generate this list using SourceKit, which is to be ported to Linux.
SourceKit uses libIndex's concept of
isTestCandidateto determine what constitutes a test.isTestCandidateis tested viatest/SourceKit/Indexing/index.swift.On Linux, however, the list of tests to be run will be generated by some tool and placed in a file that is separate from the source file that defines the test method. Therefore, the test method must not be "private", since it needs to be accessed from a separate file.
This commit adds two test files: one that verifies the behavior on Linux, and one that verifies the behavior on platforms with Objective-C interop. It also (1) simplifies the
isTestCandidatefunction, and (2) adds the interop-specific logic.This commit does not remove the existing
isTestCandidatetests intest/SourceKit/Indexing/index.swift; that is left for a future commit.ResolvedRelated bug number: (SR-710)Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Note: Only members of the Apple organization can trigger swift-ci.