Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1][ConstraintSystem] Detect and diagnose missing generic arguments #25485

Merged
merged 1 commit into from Jun 15, 2019

Conversation

xedin
Copy link
Member

@xedin xedin commented Jun 14, 2019

Introduce a fix to detect and diagnose situations when omitted
generic arguments couldn't be deduced by the solver based on
the enclosing context.

Example:

struct S<T> {
}

_ = S() // There is not enough context to deduce `T`

Cherry-pick of #25149 which has been reviewed by @slavapestov

Resolves: rdar://problem/51203824
Resolves: rdar://problem/50512161

Introduce a fix to detect and diagnose situations when omitted
generic arguments couldn't be deduced by the solver based on
the enclosing context.

Example:

```swift
struct S<T> {
}

_ = S() // There is not enough context to deduce `T`
```

Resolves: rdar://problem/51203824
@xedin xedin requested a review from DougGregor June 14, 2019 21:04
@xedin
Copy link
Member Author

xedin commented Jun 14, 2019

@swift-ci please test

@xedin xedin merged commit 004def1 into apple:swift-5.1-branch Jun 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants