Make AdditiveArithmetic.zero @_transparent #25658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution @t-ae! I'm gonna add @stephentyrone as a reviewer and kick off CI testing. @swift-ci please smoke test |
|
LGTM. @rxwei, any concerns for you? (I'm going to go ahead and merge this, just want to give you a heads up). |
stephentyrone
approved these changes
Jun 26, 2019
|
LGTM. Thanks for the heads up! |
stephentyrone
pushed a commit
to stephentyrone/swift
that referenced
this pull request
Jun 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make default implementation of
AdditiveArithmetic.zero@_transparent.Seems it is simply overlooked.