[Demangle] Fix OldDemangler DependentMemberTypeName infinite loop #25791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @rjmccall, would you be able to have a look at this? Or any suggestions on who would? |
|
@eeckstein would be the best choice, but he's not available right now. I think this is pretty safe to take, though. @swift-ci Please smoke test |
jrose-apple
approved these changes
Jun 28, 2019
|
Great, thank you! Can this be included in 5.1 as well? |
|
Linux failure seems to be unrelated |
|
It seems reasonable to me to cherry-pick, sure. @swift-ci Please smoke test |
jrose-apple
pushed a commit
to jrose-apple/swift
that referenced
this pull request
Jun 28, 2019
…ple#25791) (cherry picked from commit 9f26b99)
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OldDemanglerResolves SR-10961.