VarDecl circularity checking fixes #25848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
force-pushed
the
var-decl-circularity-fixes
branch
from
e50a08d
to
4d1665f
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
Fixes <rdar://problem/51266778>. We don't need to set the VarDecl's validation state when we go to validate the PatternBindingDecl, since the PatternBindingDecl already has its own circularity check.
Fixes <rdar://45313700>, <https://bugs.swift.org/browse/SR-9015>.
slavapestov
force-pushed
the
var-decl-circularity-fixes
branch
from
4d1665f
to
7434e37
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://problem/51266778, rdar://45313700, https://bugs.swift.org/browse/SR-9015