Serialize stdlibCore with ownership through the diagnostic passes #26608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
|
@swift-ci test source compatibility |
|
@swift-ci test linux platform |
|
The test I am expecting to fail is one of the addressor tests where we do not eliminate a struct_extract from a struct. The code is fine though and shouldn't cause issues. |
|
Build failed |
|
For the record, those are debug/release source compat suite passes. |
|
I am going to fix the ASAN error and the small addressor change and then land this. |
…t as well as when we are processing the worklist. This simplifies the IR and eliminates in a certain sense "constant information" from the IR by allowing us to remove extract, nominal literal round trips. NOTE: I had to modify the pound_assert test slightly on the location of a note that it emits. The reason that I did this is that the test output is technically correct. The instruction we are interpreting when we error is (after this commit), a debug_value in the prelude of the function (and thus has the new location). I am going to talk with Ravi and others on what to do with this.
gottesmm
force-pushed
the
ownership-onone-stdlibcore
branch
from
e39e39a
to
bd49534
Compare
|
@swift-ci test |
|
@swift-ci test source compatibility |
1 similar comment
|
@swift-ci test source compatibility |
|
Build failed |
gottesmm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going to try to land this. There is still one test that I may fix (or may just tweak slightly since the error is sort of inconsequential).
That being said, I am curious about how this looks on linux and with the source compat suite.