Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double static error message #26631

Merged
merged 6 commits into from Aug 13, 2019

Conversation

zoecarver
Copy link
Collaborator

This PR changes the error message for two static patterns in a row. For example:

class Foo {
 class static func baz() { } // old: 'static' specified twice
 static class func bar() { } // new: 'class' cannot appear after another 'static' or 'class' pattern
}

Resolves SR-11265.

Not sure if I have permissions for this: @swift-ci Please test

@theblixguy
Copy link
Collaborator

cc @rintaro

@gregomni
Copy link
Collaborator

@swift-ci Please smoke test

@gregomni
Copy link
Collaborator

I think instead of "'static' or 'class' pattern" the message should probably be "'static' or 'class' keyword". But otherwise this is a great improvement!

@zoecarver
Copy link
Collaborator Author

Updated as per your request :)

@CodaFi
Copy link
Member

CodaFi commented Aug 13, 2019

LGTM. Will manually squash this in

@swift-ci please smoke test

@CodaFi
Copy link
Member

CodaFi commented Aug 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants