[ModuleInterface] Don't print property wrapper storage vars #26845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we would print the backing _val property for a given property with a wrapper. This ended up printing incorrect output or crashing when printing the initializer for these properties, because the initializer consists of wholly-constructed calls to MyWrapper.init(wrappedValue:). We don't need these storage vars, so just omit them. Fixes rdar://53555890 and rdar://53468607
harlanhaskins
commented
Aug 26, 2019
| @@ -1485,7 +1485,7 @@ SourceRange PatternBindingEntry::getSourceRange(bool omitAccessors) const { | |||
| bool PatternBindingEntry::hasInitStringRepresentation() const { | |||
| if (InitContextAndIsText.getInt()) | |||
| return !InitStringRepresentation.empty(); | |||
| return getInit() && getInit()->getSourceRange().isValid(); | |||
| return getOriginalInit() && getOriginalInit()->getSourceRange().isValid(); | |||
There was a problem hiding this comment.
This fixes a related crash that was caused by #26416
|
Is it correct to print the |
DougGregor
approved these changes
Aug 30, 2019
|
From offline conversation: it sounds like we'd be better off printing both than printing neither, but printing both is hard. I maintain that printing just one is worse than printing neither in principle, but in practice it will only affect frozen structs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would print the backing
_valproperty for a givenproperty with a wrapper. This ended up printing incorrect output or
crashing when printing the initializer for these properties, because the
initializer consists of wholly-constructed calls to
MyWrapper.init(wrappedValue:). We don't need these storage vars, so justomit them.
Fixes rdar://53555890 and rdar://53468607