Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SR-11027 [TypeChecker][CompilerCrash] Disallow convention c/block and autoclosure #27078

Merged
merged 7 commits into from Sep 10, 2019
Merged

SR-11027 [TypeChecker][CompilerCrash] Disallow convention c/block and autoclosure #27078

merged 7 commits into from Sep 10, 2019

Conversation

LucianoPAlmeida
Copy link
Collaborator

Resolves SR-11027.
cc @dan-zheng

theblixguy
theblixguy reviewed Sep 7, 2019
View reviewed changes
lib/Sema/TypeCheckType.cpp Outdated Show resolved Hide resolved
lib/Sema/TypeCheckType.cpp Show resolved Hide resolved
include/swift/AST/DiagnosticsSema.def Outdated Show resolved Hide resolved
validation-test/compiler_crashers_2_fixed/sr11027.swift Show resolved Hide resolved
theblixguy
theblixguy approved these changes Sep 7, 2019
View reviewed changes
Copy link
Collaborator

@theblixguy theblixguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great!

@theblixguy
Copy link
Collaborator

@swift-ci please test

@xedin xedin requested a review from rintaro September 8, 2019 00:55
dan-zheng
dan-zheng approved these changes Sep 10, 2019
View reviewed changes
Copy link
Collaborator

@dan-zheng dan-zheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

xedin
xedin approved these changes Sep 10, 2019
View reviewed changes
Copy link
Member

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! If you are up for it I think we have an SR for bad diagnostics for conversions between @convension(*) attributed parameters.

@LucianoPAlmeida
Copy link
Collaborator Author

@xedin Sure I could take a look on that :)) Do you know the SR number?

@xedin
Copy link
Member

xedin commented Sep 10, 2019

@swift-ci please test source compatibility

@xedin
Copy link
Member

xedin commented Sep 10, 2019

I believe that was @hamishknight who opened that issue, he might have a SR number handy. If not, I'll dig it up :)

@LucianoPAlmeida
Copy link
Collaborator Author

@xedin This one? or any of those?

@xedin
Copy link
Member

xedin commented Sep 10, 2019

@LucianoPAlmeida At least the first one :)

@xedin
Copy link
Member

xedin commented Sep 10, 2019

Alright, let's :shipit: @rintaro can do post-commit review too

@xedin xedin merged commit 06576e5 into apple:master Sep 10, 2019
@xedin
Copy link
Member

xedin commented Sep 10, 2019

Thank you, @LucianoPAlmeida!

@LucianoPAlmeida LucianoPAlmeida mentioned this pull request Sep 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xedin xedin xedin approved these changes

@theblixguy theblixguy theblixguy approved these changes

@dan-zheng dan-zheng dan-zheng approved these changes

@rintaro rintaro Awaiting requested review from rintaro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LucianoPAlmeida @theblixguy @xedin @dan-zheng