Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoDiff] Add build-script flag for differentiable programming. #27596

Merged
merged 2 commits into from
Oct 20, 2019

Conversation

dan-zheng
Copy link
Contributor

Mirror of upstream PR: #27595.
Wait for approval on upstream PR before testing/merging this PR to ensure changes are in sync.


Add --enable-experimental-differentiable-programming build-script flag.

The build-script flag enables/disables standard library additions
related to differentiable programming. This will allow official Swift
releases to disable these additions.

The build-script flag is on by default to ensure testing of
differentiable programming standard library additions. An additional
driver flag must be enabled to use differentiable programming features:
#27446

@dan-zheng dan-zheng added the tensorflow This is for "tensorflow" branch PRs. label Oct 10, 2019
@dan-zheng dan-zheng changed the title [Autodiff] Add build-script flag for differentiable programming. [AutoDiff] Add build-script flag for differentiable programming. Oct 10, 2019
…ing. (swiftlang#27595)

Add `--enable-experimental-differentiable-programming` build-script flag.

The build-script flag enables/disables standard library additions
related to differentiable programming. This will allow official Swift
releases to disable these additions.

The build-script flag is on by default to ensure testing of
differentiable programming standard library additions. An additional
driver flag must be enabled to use differentiable programming features:
swiftlang#27446
@rxwei
Copy link
Contributor

rxwei commented Oct 15, 2019

@dan-zheng would you like to merge this in?

@dan-zheng
Copy link
Contributor Author

@dan-zheng would you like to merge this in?

Yes, I think merging this makes sense because it will make tensorflow branch in sync with master branch.


Note: the AutoDiff upstream PR #27511 will move Differentiable.swift out of stdlib/public/core and into a new _Differentiation module at stdlib/public/Differentiation, reverting changes to stdlib/public/core/CMakeLists.txt.

tensorflow branch will need a mirror of #27511 after it is merged.

@dan-zheng dan-zheng merged commit 7498390 into swiftlang:tensorflow Oct 20, 2019
@dan-zheng dan-zheng deleted the upstream-∂p-mirror branch October 20, 2019 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tensorflow This is for "tensorflow" branch PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants