[AutoDiff] Clean up. #27718
Merged
[AutoDiff] Clean up. #27718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-zheng
force-pushed
the
autodiff-cleanup
branch
from
7dde30e
to
769d518
Compare
|
Please hold off on review, more SIL parser changes are coming (code deduplication and necessary changes for #27719). EDIT: SIL parser changes done. |
- Store `AutoDiffConfig` in `SILDifferentiabilityWitness` instead of storing the individual components. This makes it cheaper to get an `AutoDiffConfig`. - Unify parsing logic and diagnostics. - Minor style changes.
dan-zheng
force-pushed
the
autodiff-cleanup
branch
from
769d518
to
0bf1af4
Compare
rxwei
approved these changes
Oct 16, 2019
|
@swift-ci Please test tensorflow |
1 similar comment
|
@swift-ci Please test tensorflow |
|
Merging to unblock progress. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AutoDiffConfiginSILDifferentiabilityWitnessinstead of storingthe individual components. This makes it cheaper to get an
AutoDiffConfig.