SR-11679: Incorrect FixIt suggestion for CFTypes #28015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theblixguy
reviewed
Nov 1, 2019
theblixguy
reviewed
Nov 1, 2019
theblixguy
reviewed
Nov 1, 2019
theblixguy
reviewed
Nov 1, 2019
theblixguy
approved these changes
Nov 1, 2019
theblixguy
reviewed
Nov 1, 2019
theblixguy
reviewed
Nov 1, 2019
Convenience inits are only allowed on classes and in extensions thereof. And in CFTypes we are not allowed to put convenince inits since swift does not support this feature yet. This PR solve the bad fix suggestion when a user declare a init method in an extension of CF Type. Another bug (similar to this one) that i found and became visible when i was doing the test cases for SR-116779 was the fact that if you declare a convenience init that delegates the init function in self, a fix suggestion will appear. The same suggestion that is causing troubles in SR-11679. The fix for this was removing the fix suggestion when the class kind type was CFType since if we leave it as is, it will be the same problem as SR-11679. SR-11679: PR Feedback Formatting the new code with clang-format and using `isa` and `cast` instead of `dyn_cast` SR-11679: PR Feedback Inlining `cast SR-11679: PR Feedback Remove semi-colon SR-11679: PR Feedback Remove empty line & add mark to avoid fixit. SR-11679: PR Feedback Remove empty line. SR-11679: PR Feedback Move Diagnostics Info & Remove empty lines
theblixguy
approved these changes
Nov 1, 2019
|
@swift-ci please smoke test |
|
Anyone knows why it failed on Linux? Is CI environment related? |
|
@swift-ci please smoke test Linux |
hborla
approved these changes
Nov 4, 2019
|
@nexon Thank you for your contribution! Please don't forget to mark the JIRA ticket as resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Convenience inits are only allowed on classes and in extensions thereof. And in CFTypes we are not allowed to put convenince inits since swift does not support this feature yet.
This PR solve the bad fix suggestion when a user declare a init method in an extension of CF Type. The simple solution was removing the fix suggestion when the ClassDecl type is CF.
Another bug (similar to this one) that i found and became visible when i was doing the test cases for SR-11679. Was the fact that if you declare a convenience init that delegates the init function in self, a fix suggestion will appear. The same suggestion that is causing troubles in SR-11679. The fix for this was removing the fix suggestion when the class kind type was CFType since if we leave it as is, it will be the same problem as SR-11679.