[SyntaxParse] Parse break statement syntax #28209
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
requested changes
Nov 13, 2019
There was a problem hiding this comment.
Thanks for continuing working on this! The change itself looks good to me.
Could you add a test case for break statement with try and code labels in test/Syntax/round_trip_parse_gen.swift? like:
switch foo {
case let a:
try break
case let b:
LABEL: break
}I believe this is parsed as UnknownStmt syntax that contains BreakStmt, but just to make sure.
kitasuke
force-pushed
the
syntax-parse-break-stmt
branch
from
f6b86b7
to
e74f103
Compare
|
Addressed your feedbacks |
[SyntaxParse] Parse break statement syntax Fix docs
kitasuke
force-pushed
the
syntax-parse-break-stmt
branch
from
e74f103
to
12abdf0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Apply new changes on syntax-parse branch to BreakStmtSyntax