[CSDiagnostics] A couple of fixes for the "self." immutability fix-it #28288
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
self.
fix-it logic for a shadowed mutable property such that it does a qualified lookup on the type which the method is a member of, which prevents it from finding unrelated results in a parent type. In addition, it adds support for shadowed static mutable properties by offering to insertType.
. Finally, it tweaks the insertion location such that it's at the start of the affected expression.Resolves SR-11786, SR-11787, and SR-11788.