[5.2] SR-7732: Dynamic casting CFError to Error results in a memory leak (from #28686) #28754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The special handling for casting CFError/NSError to Swift Error type was using cleanup code that didn't correctly handle this case. This replaces the cleanup code with a more targeted version. Fixes: SR-7732 Fixes: rdar://problem/40423061
I've verified this simplified test still leaks with the original code and does not leak with the fixed code.
tbkka
changed the title
|
Cherry-picking from #28686 as requested by @DougGregor |
|
@swift-ci Please test Linux |
|
@swift-ci Please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The special handling for casting CFError/NSError to Swift Error
type was using cleanup code that didn't correctly handle this case.
This replaces the cleanup code with a more targeted version.
Resolves SR-7732
Resolves rdar://40423061