Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AutoDiff] Fix build error. #28897

Merged
merged 1 commit into from Dec 20, 2019
Merged

[AutoDiff] Fix build error. #28897

merged 1 commit into from Dec 20, 2019

Conversation

dan-zheng
Copy link
Collaborator

Fix build error introduced in #28892: https://ci.swift.org//job/oss-swift-incremental-RA-osx/9984

/Users/buildnode/jenkins/workspace/oss-swift-incremental-RA-osx/swift/lib/Sema/TypeCheckAttr.cpp:3558:5: error: non-void function 'typeCheckDerivativeAttr' should return a value [-Wreturn-type]
00:03:51     return;
00:03:51     ^

Caused by not re-running CI after #28879 was merged, sorry about that.

@dan-zheng
[AutoDiff] Fix build error.
2692abb 
Fix build error introduced in apple#28892.

Caused by not re-running CI after apple#28879
was merged.
@dan-zheng
Copy link
Collaborator Author

@swift-ci Please smoke test

@rintaro rintaro merged commit 06014e6 into apple:master Dec 20, 2019
@dan-zheng dan-zheng deleted the derivative-attr-qualified-decl branch December 20, 2019 11:53
@dan-zheng
Copy link
Collaborator Author

@rintaro: thanks for merging! Sorry the breakage affected you and others.

@beccadax beccadax mentioned this pull request Dec 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rxwei rxwei rxwei approved these changes

@marcrasi marcrasi Awaiting requested review from marcrasi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dan-zheng @rxwei @rintaro