Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: avoid modifying user controlled flags #28929

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

build: avoid modifying user controlled flags #28929

wants to merge 2 commits into from

Commits on Dec 22, 2019

  1. build: avoid modifying CMAKE_CXX_FLAGS 

    `CMAKE_CXX_FLAGS` is meant to be user-controlled.  Use modern CMake
techniques to avoid modifying the `CMAKE_CXX_FLAGS` now that we use a
sufficiently modern CMake on all platforms.
    @compnerd
    compnerd committed Dec 22, 2019
    Configuration menu
    Copy the full SHA
    5695826 View commit details
    Browse the repository at this point in the history

  2. build: clean up some compatibility deadcode 

    We use a newer CMake on all the build targets now, so remove the
compatibility shim.
    @compnerd
    compnerd committed Dec 22, 2019
    Configuration menu
    Copy the full SHA
    168083d View commit details
    Browse the repository at this point in the history