[AutoDiff] Deprecate @differentiable(jvp:vjp:) arguments.
#28932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecate `@differentiable` attribute `jvp:` and `vjp:` arguments for derivative registration. `@derivative` attribute is the canonical way to register derivatives. Update tests. TF-1001 tracks removing `@differentiable` attribute `jvp:` and `vjp:` arguments. TF-1085 tracks removing `@differentiable(jvp:vjp:)` usages in the stdlib.
dan-zheng
commented
Dec 23, 2019
| @@ -1021,6 +1021,13 @@ bool Parser::parseDifferentiableAttributeArguments( | |||
| { label }); | |||
| result.Name = parseDeclNameRef(result.Loc, funcDiag, | |||
| DeclNameFlag::AllowZeroArgCompoundNames | DeclNameFlag::AllowOperators); | |||
| // Emit warning for deprecated `jvp:` and `vjp:` arguments. | |||
| // TODO(TF-1001): Remove deprecated `jvp:` and `vjp:` arguments. | |||
| if (result.Loc.isValid()) { | |||
There was a problem hiding this comment.
Note: result.Loc may not be valid if parseDeclNameRef produces an error.
This can happen when jvp:vjp: specifies a non-func declaration, e.g. an init or subscript.
|
@swift-ci Please test tensorflow |
rxwei
approved these changes
Dec 23, 2019
rxwei
approved these changes
Dec 23, 2019
bartchr808
approved these changes
Dec 23, 2019
|
There'll be stdlib compilation warnings until |
dan-zheng
added a commit
to dan-zheng/swift
that referenced
this pull request
Jan 7, 2020
Upstream changes from `tensorflow` branch: - apple#28932: deprecate `@differentiable(jvp:vjp)` arguments. - apple#29038: gardening. Additional gardening included.
dan-zheng
added a commit
that referenced
this pull request
Jan 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate
@differentiableattributejvp:vjp:arguments for derivativeregistration.
@derivativeattribute is the canonical way to registerderivatives.
Update tests.
TF-1001 tracks removing
@differentiableattributejvp:andvjp:arguments.TF-1085 tracks removing
@differentiable(jvp:vjp:)usages in the stdlib.Todo: upstream this PR to
master.Example:
I decided not to invest time writing fully-fledged fix-its for rewriting
@differentiable(jvp:vjp:)usages to@derivativeattribute, as it's slightly non-trivial. We can focus on retrodiff progress and manually rewriting@differentiable(jvp:vjp:)usages instead.