Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: treat SourceKit as a host tool #29457

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

compnerd
Copy link
Collaborator

This changes the SourceKit build to use the host configuration. This is
the appropriate way to handle the build of SourceKit as it is not a
target component. Doing so simplifies the build, makes it more obvious
how to migrate the SourceKit build to the standard CMake build
techniques.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

This changes the SourceKit build to use the host configuration.  This is
the appropriate way to handle the build of SourceKit as it is not a
target component.  Doing so simplifies the build, makes it more obvious
how to migrate the SourceKit build to the standard CMake build
techniques.
@compnerd
Copy link
Collaborator Author

@swift-ci please clean test

@compnerd
Copy link
Collaborator Author

CC: @Rostepher @edymtt @xiaobai @akyrtzi

@akyrtzi
Copy link
Member

akyrtzi commented Jan 26, 2020

\cc @benlangmuir

We have internal clients that cross-compile SourceKit for iOS, though I'm unfamiliar with how exactly they configure. Will these changes prevent SourceKit from being buildable for iOS?
Or is this similar to how the compiler binary itself is configured so cross-compilation will work the same?

@compnerd
Copy link
Collaborator Author

Yeah, its the same way that the compiler cross-compiles itself that you would do to build it for iOS. Are you building SourceKit or the swift-lang bits for iOS btw? Because that has a whole other set of complexity :(

@akyrtzi
Copy link
Member

akyrtzi commented Jan 27, 2020

Just the C++ SourceKit code.

@benlangmuir
Copy link
Member

The principle here seems correct to me. Do you have any suggestions for seeing what exactly will change in practice? Configure with ninja and then dump the commands I guess?

@compnerd
Copy link
Collaborator Author

Yeah, that would be the most effective way to identify the practical change.

@shahmishal
Copy link
Member

Please update the base branch to main by Oct 5th otherwise the pull request will be closed automatically.

  • How to change the base branch: (Link)
  • More detail about the branch update: (Link)

@compnerd compnerd changed the base branch from master to main October 1, 2020 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants