New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: treat SourceKit as a host tool #29457
base: main
Are you sure you want to change the base?
Conversation
This changes the SourceKit build to use the host configuration. This is the appropriate way to handle the build of SourceKit as it is not a target component. Doing so simplifies the build, makes it more obvious how to migrate the SourceKit build to the standard CMake build techniques.
@swift-ci please clean test |
\cc @benlangmuir We have internal clients that cross-compile SourceKit for iOS, though I'm unfamiliar with how exactly they configure. Will these changes prevent SourceKit from being buildable for iOS? |
Yeah, its the same way that the compiler cross-compiles itself that you would do to build it for iOS. Are you building SourceKit or the swift-lang bits for iOS btw? Because that has a whole other set of complexity :( |
Just the C++ SourceKit code. |
The principle here seems correct to me. Do you have any suggestions for seeing what exactly will change in practice? Configure with ninja and then dump the commands I guess? |
Yeah, that would be the most effective way to identify the practical change. |
This changes the SourceKit build to use the host configuration. This is
the appropriate way to handle the build of SourceKit as it is not a
target component. Doing so simplifies the build, makes it more obvious
how to migrate the SourceKit build to the standard CMake build
techniques.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.