Remove quasiquotes from the tensorflow branch #29571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @burmako ! |
|
@swift-ci Please clean test tensorflow |
added 2 commits
February 5, 2020 08:40
Quasiquotes were introduced in the tensorflow branch as a promising approach to metaprogramming to power our work on Swift MLIR, but we found a SIL-based approach to be more useful for the case studies that we currently have in mind. Aside from Swift MLIR, we don't have any other use cases for quasiquotes, so I'm suggesting we remove them to: 1) reduce the delta between tensorflow and master which goes along the lines of our long-term plans to converge these two branches, 2) simplify weekly merges.
|
@swift-ci Please clean test tensorflow |
1 similar comment
|
@swift-ci Please clean test tensorflow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quasiquotes were introduced in the tensorflow branch as a promising approach
to metaprogramming to power our work on Swift MLIR, but we found a SIL-based
approach to be more useful for the case studies that we currently have in mind.
Aside from Swift MLIR, we don't have any other use cases for quasiquotes,
so I'm suggesting we remove them to: 1) reduce the delta between tensorflow and
master which goes along the lines of our long-term plans to converge these two
branches, 2) simplify weekly merges.