[DNM] Use normalized paths when emitting a module trace. #29967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test Windows platform |
|
Actually, this is not 100% right, because when we search, we should normalize the paths as well. |
|
@swift-ci please smoke test |
|
But I think this should work as a temporary fix since the paths that are problematic are the ones in the map. I wrote some code to normalize the paths that are being looked up, but that crashed for some odd reason inside DenseMap's find, probably a lifetime problem 😕. |
|
@swift-ci please test Windows platform |
Merged
|
@swift-ci please test Windows platform |
|
Marking DNM temporarily, I'll get back to this on the weekend. |
varungandhi-apple
changed the title
|
@swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.