Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Typechecker] Use getCalledValue() when checking ignored expressions #30077

Merged
merged 1 commit into from Feb 26, 2020
Merged

[Typechecker] Use getCalledValue() when checking ignored expressions #30077

merged 1 commit into from Feb 26, 2020

Conversation

theblixguy
Copy link
Collaborator

Instead of extracting the function declaration from the DeclRefExpr, use getCalledValue() instead. Otherwise, we throw the expression resolves to an unused function diagnostic for:

struct Foo {
  @discardableResult
  func bar() -> () -> Void { return {} }
}

Foo().bar() // error: expression resolves to an unused function

because we're not able to get back the function declaration in order to determine if it's been annotated with @discardableResult or not.

Fixes SR-12271

…et the function decl when checking ignored expressions
@theblixguy
Copy link
Collaborator Author

@swift-ci please smoke test

Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants