Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[opt] remove dead partial apply in mandatory combine #30554

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[opt] remove dead partial apply in mandatory combine #30554

wants to merge 1 commit into from

Conversation

zoecarver
Copy link
Collaborator

This patch adds support for cleaning up dead partial applies using tryDeleteDeadClosure. Ref #30475.

@zoecarver zoecarver requested a review from gottesmm March 21, 2020 16:17
@zoecarver zoecarver force-pushed the optimize/mand-combine-partial-apply branch from 23f0c43 to 7a048ea Compare April 10, 2020 16:50
@zoecarver
Copy link
Collaborator Author

zoecarver commented Apr 10, 2020 •
edited

We don't need tryDeleteDeadClosure after #30429 lands.

Edit: note the tests will not pass until #30429 is applied.

@shahmishal
Copy link
Member

Please update the base branch to main by Oct 5th otherwise the pull request will be closed automatically.

  • How to change the base branch: (Link)
  • More detail about the branch update: (Link)

@zoecarver zoecarver changed the base branch from master to main October 2, 2020 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gottesmm gottesmm Awaiting requested review from gottesmm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zoecarver @shahmishal