[Sema] Fix a couple of property override crashers #30792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only apply the relevant property wrapper mutability when we're performing an access via the wrapped value.
Before attempting to get the superclass of a self parameter type, check to see if we have a metatype, and perform the necessary unwrapping and re-wrapping if needed.
hamishknight
force-pushed
the
storage-access-codes
branch
from
7d27d4f
to
6a7b2e0
Compare
|
@swift-ci please test |
slavapestov
approved these changes
Apr 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust
buildStorageReferenceto handle metatype self parameters, and to ignore property wrapper mutability when not accessing via the wrapped value.Resolves SR-12443 & SR-12456.
Resolves rdar://problem/61090634.