[SR-12242] Apply to Arg involving ConstraintLocator::GenericArgument diagnostics improvement #30814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstraintLocator::GenericArgument
LucianoPAlmeida
force-pushed
the
SR-12242-generic-arg-diag-improvement
branch
from
b0c11b0
to
75b7b7b
Compare
LucianoPAlmeida
force-pushed
the
SR-12242-generic-arg-diag-improvement
branch
from
75b7b7b
to
b255b09
Compare
|
Right, all set |
LucianoPAlmeida
force-pushed
the
SR-12242-generic-arg-diag-improvement
branch
2 times, most recently
from
36dc3f2
to
53ddf78
Compare
hamishknight
reviewed
Apr 6, 2020
LucianoPAlmeida
force-pushed
the
SR-12242-generic-arg-diag-improvement
branch
2 times, most recently
from
1086e4c
to
7e1bf4c
Compare
…optionals diagnostics
LucianoPAlmeida
force-pushed
the
SR-12242-generic-arg-diag-improvement
branch
from
7e1bf4c
to
16ac70f
Compare
hamishknight
approved these changes
Apr 6, 2020
|
@swift-ci please test |
|
@swift-ci please test Windows |
xedin
approved these changes
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just improving diagnostics for Generic Mismatch involving argument conversion.
cc @xedin @hborla :)
Resolves SR-12242.