Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[validation-test] avoid crash in StringUTF8 #30985

Closed
wants to merge 1 commit into from

Conversation

omochi
Copy link
Collaborator

@omochi omochi commented Apr 12, 2020

To avoid crash, it uses optional binding.

Resolves half: https://bugs.swift.org/browse/SR-12577

Test case fail as usual, but it will be improved so that detailed output can be obtained.

Example:

[ RUN      ] StringUTF8Tests.Contiguous Access
stdout>>> abcd
stdout>>> abcdefghijklmnop
stdout>>> check failed at /Users/omochi/work/swift-source/swift/validation-test/stdlib/StringUTF8.swift, line 69
stdout>>> expected: true
stdout>>> check failed at /Users/omochi/work/swift-source/swift/validation-test/stdlib/StringUTF8.swift, line 72
stdout>>> expected optional to be non-nil
stdout>>> abcdéfghijk
stdout>>> á
stdout>>> 👻
stdout>>> Spooky long string. 👻
stdout>>> в чащах юга жил-был цитрус? да, но фальшивый экземпляр
stdout>>> 日

@milseman @Catfish-Man Could you review this?

To avoid crash, it uses optional binding.

Resolves half: https://bugs.swift.org/browse/SR-12577
@omochi
Copy link
Collaborator Author

omochi commented Apr 12, 2020

@swift-ci Please smoke test

@milseman
Copy link
Contributor

@Catfish-Man, could you review?

@milseman
Copy link
Contributor

@swift-ci please test

@milseman
Copy link
Contributor

Full test is needed for validation tests

@omochi
Copy link
Collaborator Author

omochi commented Apr 14, 2020

OK. I will do so in next time.

@shahmishal
Copy link
Member

Please update the base branch to main by Oct 5th otherwise the pull request will be closed automatically.

  • How to change the base branch: (Link)
  • More detail about the branch update: (Link)

@shahmishal shahmishal closed this Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants