Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove integrated REPL #31187

Merged
merged 4 commits into from
May 7, 2020

Conversation

slavapestov
Copy link
Contributor

@slavapestov slavapestov commented Apr 21, 2020

The integrated REPL has been deprecated in favor of the LLDB REPL for a while, and the implementation had accumulated some amount of technical debt throughout the code base. Since most people don't use it and are not even aware that it exists, we can remove it.

Note that this does not impact usage of the LLDB REPL (lldb --repl or just swift), Swift expression evaluation in LLDB, or the ability to run Swift scripts in immediate mode (swift foo.swift).

Forum discussion: https://forums.swift.org/t/rfc-removing-the-integrated-repl/35441

@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test

@slavapestov
Copy link
Contributor Author

Well, I guess this won't work, because there's no way to just run lldb tests.

@dcci
Copy link
Member

dcci commented Apr 21, 2020

Nevermind, I guess this is because it doesn't compile.

@slavapestov slavapestov changed the title (Experiment) Remove integrated REPL Remove integrated REPL May 7, 2020
@slavapestov slavapestov marked this pull request as ready for review May 7, 2020 00:07
@slavapestov
Copy link
Contributor Author

swiftlang/llvm-project#1188
@swift-ci Please smoke test

@johanatan
Copy link

👍🏻

@slavapestov slavapestov merged commit 590f83c into swiftlang:master May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants