-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove integrated REPL #31187
Merged
slavapestov
merged 4 commits into
swiftlang:master
from
slavapestov:remove-integrated-repl
May 7, 2020
Merged
Remove integrated REPL #31187
slavapestov
merged 4 commits into
swiftlang:master
from
slavapestov:remove-integrated-repl
May 7, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@swift-ci Please smoke test |
Well, I guess this won't work, because there's no way to just run lldb tests. |
dcci
reviewed
Apr 21, 2020
Nevermind, I guess this is because it doesn't compile. |
slavapestov
force-pushed
the
remove-integrated-repl
branch
from
May 7, 2020 00:06
71b03b8
to
ef6a978
Compare
slavapestov
changed the title
(Experiment) Remove integrated REPL
Remove integrated REPL
May 7, 2020
slavapestov
force-pushed
the
remove-integrated-repl
branch
from
May 7, 2020 06:07
ef6a978
to
2a388b5
Compare
swiftlang/llvm-project#1188 |
👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The integrated REPL has been deprecated in favor of the LLDB REPL for a while, and the implementation had accumulated some amount of technical debt throughout the code base. Since most people don't use it and are not even aware that it exists, we can remove it.
Note that this does not impact usage of the LLDB REPL (
lldb --repl
or justswift
), Swift expression evaluation in LLDB, or the ability to run Swift scripts in immediate mode (swift foo.swift
).Forum discussion: https://forums.swift.org/t/rfc-removing-the-integrated-repl/35441