Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoDiff] Enable cross-file derivative registration by default. #31249

Conversation

dan-zheng
Copy link
Collaborator

Enable cross-file derivative registration by default on tensorflow branch.
Cross-file derivative registration is already enabled on master branch.

Remove -enable-experimental-cross-file-derivative-registration flag, which was
never upstreamed to master.

Resolves TF-1097.


This brings tensorflow in sync with master.

Todos:

Enable cross-file derivative registration by default on tensorflow branch.
Cross-file derivative registration is already enabled on master branch.

Remove `-enable-experimental-cross-file-derivative-registration` flag, which was
never upstreamed to master.

Resolves TF-1097.
@dan-zheng dan-zheng added the tensorflow This is for "tensorflow" branch PRs. label Apr 23, 2020
@dan-zheng
Copy link
Collaborator Author

@swift-ci Please test tensorflow

@rxwei
Copy link
Member

rxwei commented Apr 23, 2020

Did we land #29987 on master? I think there's quite a few stability issues with cross-file derivative registration with mismatching access levels. It would be better if #29987 lands first on master. But since this PR is about the tensorflow branch, I'll let you guys decide.

@dan-zheng
Copy link
Collaborator Author

Did we land #29987 on master? I think there's quite a few stability issues with cross-file derivative registration with mismatching access levels. It would be better if #29987 lands first on master. But since this PR is about the tensorflow branch, I'll let you guys decide.

#29987 hasn't landed on master yet, I'll look into it soon to address potential issues from mismatching access levels. This PR just makes tensorflow branch consistent with master.

@dan-zheng dan-zheng merged commit 5c3508b into apple:tensorflow Apr 24, 2020
@dan-zheng dan-zheng deleted the enable-cross-file-derivative-registration branch April 24, 2020 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tensorflow This is for "tensorflow" branch PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants