Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-12672] Tailored diagnostics for missing member involving array literal default to any element #31366

Merged
merged 3 commits into from Apr 28, 2020
Merged

[SR-12672] Tailored diagnostics for missing member involving array literal default to any element #31366

merged 3 commits into from Apr 28, 2020

Conversation

LucianoPAlmeida
Copy link
Collaborator

Tailored diagnostics for missing member involving array literal default to any element.

Resolves SR-12672.

cc @xedin @varungandhi-apple

xedin
xedin reviewed Apr 28, 2020
View reviewed changes
lib/Sema/CSDiagnostics.cpp Show resolved Hide resolved
lib/Sema/CSDiagnostics.h Outdated Show resolved Hide resolved
@varungandhi-apple
Copy link
Contributor

@LucianoPAlmeida just a heads-up: I have a PR up which I'm going to merge soon-ish #31315. That change the name for the diagnostic, so you'll need to rebase this PR on top of that.

@LucianoPAlmeida
Copy link
Collaborator Author

@LucianoPAlmeida just a heads-up: I have a PR up which I'm going to merge soon-ish #31315. That change the name for the diagnostic, so you'll need to rebase this PR on top of that.

No problem @varungandhi-apple :)

@LucianoPAlmeida LucianoPAlmeida force-pushed the SR-12672-diagnostics branch 2 times, most recently from 327c876 to ce97427 Compare April 28, 2020 19:42
xedin
xedin reviewed Apr 28, 2020
View reviewed changes
lib/Sema/CSDiagnostics.cpp Outdated Show resolved Hide resolved
lib/Sema/CSDiagnostics.cpp Outdated Show resolved Hide resolved
lib/Sema/CSDiagnostics.cpp Outdated Show resolved Hide resolved
lib/Sema/CSDiagnostics.cpp Outdated Show resolved Hide resolved
lib/Sema/CSDiagnostics.h Outdated Show resolved Hide resolved
lib/Sema/CSDiagnostics.h Outdated Show resolved Hide resolved
@LucianoPAlmeida
Copy link
Collaborator Author

All adjusted @xedin :)

@xedin
Copy link
Member

xedin commented Apr 28, 2020

@swift-ci please smoke test

@LucianoPAlmeida
Copy link
Collaborator Author

@varungandhi-apple I was looking to the PR you merged seems like it doesn't affect this diagnostic message, so not sure if we need to rebase here ...

@varungandhi-apple
Copy link
Contributor

@LucianoPAlmeida oops, sorry about that! I got confused; I was working on changing the member inference diagnostic but that is still local and unfinished, not in a PR. Please go ahead and merge. 😄

@xedin xedin merged commit a400c74 into apple:master Apr 28, 2020
@xedin
Copy link
Member

xedin commented Apr 28, 2020

@LucianoPAlmeida Let's get this into 5.3 branch as well.

@xedin
Copy link
Member

xedin commented Apr 28, 2020

Note that you'd have to remove castToExpr from there because 5.3 doesn't have that refactoring.

@LucianoPAlmeida
Copy link
Collaborator Author

Sure @xedin! :)

@LucianoPAlmeida LucianoPAlmeida mentioned this pull request Apr 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xedin xedin xedin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LucianoPAlmeida @varungandhi-apple @xedin