Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIL: Thread type expansion context through to function convention apis #31470

Merged
merged 3 commits into from May 6, 2020

Conversation

aschwaighofer
Copy link
Member

This became necessary after recent function type changes that keep
substituted generic function types abstract even after substitution to
correctly handle automatic opaque result type substitution.

Instead of performing the opaque result type substitution as part of
substituting the generic args the underlying type will now be reified as
part of looking at the parameter/return types which happens as part of
the function convention apis.

rdar://62560867

@aschwaighofer
Copy link
Member Author

@swift-ci Please test

@swift-ci
Copy link
Collaborator

swift-ci commented May 1, 2020

Build failed
Swift Test Linux Platform
Git Sha - 1f1b62ab7e8de40bd138955e11b6123cb0b649db

@aschwaighofer
Copy link
Member Author

@swift-ci Please test

@swift-ci
Copy link
Collaborator

swift-ci commented May 1, 2020

Build failed
Swift Test Linux Platform
Git Sha - 1f1b62ab7e8de40bd138955e11b6123cb0b649db

@swift-ci
Copy link
Collaborator

swift-ci commented May 1, 2020

Build failed
Swift Test OS X Platform
Git Sha - 1f1b62ab7e8de40bd138955e11b6123cb0b649db

@aschwaighofer
Copy link
Member Author

@swift-ci Please test

@swift-ci
Copy link
Collaborator

swift-ci commented May 1, 2020

Build failed
Swift Test Linux Platform
Git Sha - 34e9f027b765071dcb4b00a14efdd95eaa85f13f

@swift-ci
Copy link
Collaborator

swift-ci commented May 1, 2020

Build failed
Swift Test OS X Platform
Git Sha - 34e9f027b765071dcb4b00a14efdd95eaa85f13f

This became necessary after recent function type changes that keep
substituted generic function types abstract even after substitution to
correctly handle automatic opaque result type substitution.

Instead of performing the opaque result type substitution as part of
substituting the generic args the underlying type will now be reified as
part of looking at the parameter/return types which happens as part of
the function convention apis.

rdar://62560867
@aschwaighofer
Copy link
Member Author

@swift-ci Please test

@aschwaighofer
Copy link
Member Author

@swift-ci Please test source compatibility

@swift-ci
Copy link
Collaborator

swift-ci commented May 4, 2020

Build failed
Swift Test OS X Platform
Git Sha - cf325a9b40cf7db5af932e956a0d8b28203b9d44

@swift-ci
Copy link
Collaborator

swift-ci commented May 4, 2020

Build failed
Swift Test Linux Platform
Git Sha - cf325a9b40cf7db5af932e956a0d8b28203b9d44

@aschwaighofer
Copy link
Member Author

@swift-ci Please test os x

@swift-ci
Copy link
Collaborator

swift-ci commented May 4, 2020

Build failed
Swift Test OS X Platform
Git Sha - 147144b

@aschwaighofer
Copy link
Member Author

@swift-ci please test source compatibility debug

@aschwaighofer
Copy link
Member Author

@swift-ci Please test

@aschwaighofer
Copy link
Member Author

@swift-ci Please test source compatibility

@swift-ci
Copy link
Collaborator

swift-ci commented May 5, 2020

Build failed
Swift Test OS X Platform
Git Sha - 147144b

@swift-ci
Copy link
Collaborator

swift-ci commented May 5, 2020

Build failed
Swift Test Linux Platform
Git Sha - 147144b

@aschwaighofer
Copy link
Member Author

@swift-ci Please test source compatibility debug

1 similar comment
@aschwaighofer
Copy link
Member Author

@swift-ci Please test source compatibility debug

@aschwaighofer
Copy link
Member Author

@swift-ci Please test

@swift-ci
Copy link
Collaborator

swift-ci commented May 6, 2020

Build failed
Swift Test OS X Platform
Git Sha - 36f25ee

@swift-ci
Copy link
Collaborator

swift-ci commented May 6, 2020

Build failed
Swift Test Linux Platform
Git Sha - 36f25ee

@aschwaighofer aschwaighofer merged commit 970c272 into apple:master May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants