Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClangImporter: support __isoc_va_list for WASI/musl #31692

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

ClangImporter: support __isoc_va_list for WASI/musl #31692

wants to merge 1 commit into from

Conversation

MaxDesiatov
Copy link
Member

@MaxDesiatov MaxDesiatov commented May 10, 2020 •
edited

__isoc_va_list is used in musl and WASI libc, as the latter is based on musl. It would be great to support this variant in ClangImport to improve support for those environments.

Related to SR-9307.

@MaxDesiatov MaxDesiatov mentioned this pull request May 10, 2020
Closed
78 tasks
@compnerd
Copy link
Collaborator

This seems reasonable, but should have an accompanying test.

@MaxDesiatov MaxDesiatov changed the base branch from master to main September 24, 2020 08:41
@MaxDesiatov MaxDesiatov force-pushed the maxd/isoc-va-list branch 3 times, most recently from 0e432a3 to d4754e2 Compare December 8, 2020 18:34
@MaxDesiatov
Copy link
Member Author

@swift-ci please smoke test

@MaxDesiatov
Copy link
Member Author

@swift-ci please test OS X platform

@MaxDesiatov
Copy link
Member Author

@swift-ci please smoke test OS X platform

@swift-ci
Copy link
Collaborator

swift-ci commented Dec 8, 2020

Build failed
Swift Test OS X Platform
Git Sha - d4754e2

@MaxDesiatov
Copy link
Member Author

@swift-ci please clean test

@swift-ci
Copy link
Collaborator

Build failed
Swift Test Linux Platform
Git Sha - d4754e2

@swift-ci
Copy link
Collaborator

Build failed
Swift Test OS X Platform
Git Sha - d4754e2

@MaxDesiatov
Copy link
Member Author

@swift-ci please smoke test

@MaxDesiatov
Copy link
Member Author

@swift-ci please test Windows platform

@kateinoigakukun
Copy link
Member

@swift-ci Please smoke test

@MaxDesiatov
Copy link
Member Author

I'd expect these to fail, for some reason the test always fails for me on x86, but passes on arm64, I still have no idea why

@MaxDesiatov
Copy link
Member Author

MaxDesiatov commented Oct 19, 2021 •
edited

I'd expect these to fail, for some reason the test always fails for me on x86, but passes on arm64

@zoecarver since you're working on ClangImporter, maybe you've seen something like this before?

@kateinoigakukun
Copy link
Member

I guess there is some difference on va_list ABI between arm64 and x64. Could you try to replace variables with functions like void use_va(va_list); in the test?

@DougGregor
Copy link
Member

@swift-ci please smoke test

@MaxDesiatov MaxDesiatov deleted the maxd/isoc-va-list branch October 11, 2023 19:04
@MaxDesiatov
Copy link
Member Author

Closed as outdated.

@kateinoigakukun kateinoigakukun mentioned this pull request Mar 18, 2024
Open
@MaxDesiatov MaxDesiatov restored the maxd/isoc-va-list branch March 18, 2024 19:58
@MaxDesiatov MaxDesiatov reopened this Mar 18, 2024
@MaxDesiatov MaxDesiatov marked this pull request as draft March 18, 2024 19:58
@MaxDesiatov MaxDesiatov self-assigned this Mar 18, 2024
@MaxDesiatov MaxDesiatov added WebAssembly Platform: WebAssembly clang importer Area → compiler: The clang importer labels Mar 18, 2024
@apple apple deleted a comment from thomasbarwanitz Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoecarver zoecarver Awaiting requested review from zoecarver zoecarver is a code owner

@hyp hyp Awaiting requested review from hyp hyp is a code owner

@egorzhdan egorzhdan Awaiting requested review from egorzhdan egorzhdan is a code owner

Assignees

@MaxDesiatov MaxDesiatov

Labels
clang importer Area → compiler: The clang importer WebAssembly Platform: WebAssembly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@MaxDesiatov @compnerd @swift-ci @kateinoigakukun @DougGregor