New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Typechecker] Emit a specialised diagnostic for redeclaration errors when the declaration is synthesised #31915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xwu
reviewed
May 20, 2020
…when the declaration is synthesized
xwu
reviewed
May 20, 2020
…earest non-implicit decl context
@swift-ci please smoke test |
@swift-ci please smoke test |
hborla
approved these changes
May 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you @theblixguy !
@theblixguy yes, please prepare a PR for the 5.3 branch. Thank you! |
This was referenced May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, some redeclaration errors involving synthesised declarations can cause compiler crashes. For example:
This currently crashes in the AST verifier on master and in SILGen on 5.3. Upon investigation, this seems to be a regression caused by #31037.
To fix the problem, I have added a specialised diagnostic for situations where the current declaration is synthesised. This also fixes a problem where the redeclaration diagnostics did not have a valid source location.
Resolves SR-12839
Resolves rdar://problem/63496795