[Sema] NFC: Split test expectation to lines in object_literals
#31984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
approved these changes
May 22, 2020
xedin
changed the title
object_literalsobject_literals
|
Oh I made a mistake. |
Split lines as they has only one expectation. It helps to review changes of diagnostics in future.
omochi
force-pushed
the
split-line-test-expectation
branch
from
a79d9ab
to
f9c8210
Compare
|
No worries! |
|
@swift-ci please smoke test |
|
One last error doesn’t relate to this patch. |
|
Hum its still blocked @swift-ci please smoke test OS X |
|
@swift-ic please smoke test |
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split lines as they has only one expectation at
object_literals_osx.swift,object_literals_ios.swift.It helps to review changes of diagnostics in future.
This patch changes only line breaking of test expectation comment
and doesn't have changes of compiler.
I planned this patch in response to comment here.
#31934
@xedin Please also review this.