stdlib, SIL optimizer: use the SIL copy-on-write representation in the Array types. #32134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
@swift-ci benchmark |
|
Build failed |
|
@swift-ci test macOS |
Performance: -O
Code size: -O
Performance: -Osize
Code size: -Osize
Performance: -Onone
Code size: -swiftlibs
How to read the dataThe tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.If you see any unexpected regressions, you should consider fixing the Noise: Sometimes the performance results (not code size!) contain false Hardware Overview |
|
Build failed |
|
Build failed |
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
|
Build failed |
|
Build failed |
|
@swift-ci clean test |
|
Build failed |
|
Build failed |
|
@swift-ci clean test |
|
Build failed |
|
@swift-ci clean test |
|
Build failed |
|
Build failed |
|
@swift-ci clean test macOS |
1 similar comment
|
@swift-ci clean test macOS |
|
@swift-ci clean test linux |
|
Build failed |
|
Build failed |
|
@swift-ci test |
|
@swift-ci clean test |
1 similar comment
|
@swift-ci clean test |
|
Build failed |
|
Build failed |
|
@swift-ci clean test |
|
Build failed |
|
Build failed |
|
@swift-ci clean test macOS |
|
@swift-ci smoke test macOS |
1 similar comment
|
@swift-ci smoke test macOS |
|
Build failed |
|
@swift-ci clean smoke test macOS |
|
@swift-ci smoke test macOS |
Update differentiation to handle `array.finalize_intrinsic` applications. `VJPEmitter::visitApplyInst` does standard cloning for these applications. `PullbackEmitter::visitApplyInst` treats the intrinsic like an identity function, accumulating result's adjoint into argument's adjoint. This fixes array literal initialization differentiation.
This fixes a correctness issue. The begin_cow_mutation instruction has dependencies with instructions which retain the buffer operand. This prevents optimizations from moving begin_cow_mutation instructions across such retain instructions.
For COW support in SIL it's required to "finalize" array literals. _finalizeUninitializedArray is a compiler known stdlib function which is called after all elements of an array literal are stored. This runtime function marks the array literal as finished. %uninitialized_result_tuple = apply %_allocateUninitializedArray(%count) %mutable_array = tuple_extract %uninitialized_result_tuple, 0 %elem_base_address = tuple_extract %uninitialized_result_tuple, 1 ... store %elem_0 to %elem_addr_0 store %elem_1 to %elem_addr_1 ... %final_array = apply %_finalizeUninitializedArray(%mutable_array) In this commit _finalizeUninitializedArray is still a no-op because the COW support is not used in the Array implementation yet.
…COW buffer runtime checking. In an assert built of the library, store an extra boolean flag (isImmutable) in the object side-buffer table. This flag can be set and get by the Array implementation to sanity check the immutability status of the buffer object.
…e Array types. Use the new builtins for COW representation in Array, ContiguousArray and ArraySlice. The basic idea is to strictly separate code which mutates an array buffer from code which reads from an array. The concept is explained in more detail in docs/SIL.rst, section "Copy-on-Write Representation". The main change is to use beginCOWMutation() instead of isUniquelyReferenced() and insert endCOWMutation() at the end of all mutating functions. Also, reading from the array buffer must be done differently, depending on if the buffer is in a mutable or immutable state. All the required invariants are enforced by runtime checks - but only in an assert-build of the library: a bit in the buffer object side-table indicates if the buffer is mutable or not. Along with the library changes, also two optimizations needed to be updated: COWArrayOpt and ObjectOutliner.
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
|
Build failed |
Some lldb tests are failing with that.
|
@swift-ci clean smoke test |
1 similar comment
|
@swift-ci clean smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new builtins for COW representation in Array, ContiguousArray and ArraySlice.
The basic idea is to strictly separate code which mutates an array buffer from code which reads from an array.
The concept is explained in more detail in docs/SIL.rst, section "Copy-on-Write Representation".
The main change is to use beginCOWMutation() instead of isUniquelyReferenced() and insert endCOWMutation() at the end of all mutating functions. Also, reading from the array buffer must be done differently, depending on if the buffer is in a mutable or immutable state.
All the required invariants are enforced by runtime checks - but only in an assert-build of the library: a bit in the buffer flags indicates if the buffer is mutable or not.
Along with the library changes, also two optimizations needed to be updated: COWArrayOpt and ObjectOutliner.
Another notable change is the new library intrinsic to "finalize" array literals: for COW support in SIL it's required to "finalize" array literals.
_finalizeUninitializedArrayis a compiler known stdlib function which is called after all elements of an array literal are stored.This runtime function marks the array literal as finished.